[webkit-reviews] review requested: [Bug 58677] globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining : [Attachment 89824] Patch to move globalObject() to JSObjectWithGlobalObject.h

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 58677: globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining
https://bugs.webkit.org/show_bug.cgi?id=58677

Attachment 89824: Patch to move globalObject() to JSObjectWithGlobalObject.h
https://bugs.webkit.org/attachment.cgi?id=89824&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
As part of r60057, globalObject() was moved from JSDOMBinding.h to
JSObjectWithGlobalObject.cpp.  This limits a compilers ability to inline,
especially in other components, namely WebCore.  This is causing a performance
regression.

Moving globalObject() back to a .h file is worth ~5% on the dromaeo DOM
benchmark.