[webkit-reviews] review denied: [Bug 58656] [Qt] X11: Text selection is causing oncopy event to be called : [Attachment 89813] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 58656: [Qt] X11: Text selection is causing oncopy event to be called
https://bugs.webkit.org/show_bug.cgi?id=58656

Attachment 89813: Patch
https://bugs.webkit.org/attachment.cgi?id=89813&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89813&action=review

r- because of the empty ChangeLog.

> Source/WebKit/qt/Api/qwebpage.cpp:750
> -		   focusFrame->editor()->copy();
> +		  
Pasteboard::generalPasteboard()->writeSelection(focusFrame->editor()->selectedR
ange().get(), focusFrame->editor()->canSmartCopyOrDelete(), focusFrame);

Editor::copy() will make a text-only copy if the selection is inside a text
form control.
After this change, we always make multi-part copies (with rich-text metadata.)
Does this match the behavior of Chromium on Linux? I.e do copies made using X11
selection contain rich-text data?

> Source/WebKit/qt/ChangeLog:6
> +	   [Qt] Text selection is causing oncopy event be called
> +	   https://bugs.webkit.org/show_bug.cgi?id=58656

We need more explanation of what's being changed and why in the ChangeLog.