[webkit-reviews] review denied: [Bug 58064] Web Inspector: Network events don't preserves, when inspector frontend closed and open again : [Attachment 89787] Fix style
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 15 07:52:52 PDT 2011
Yury Semikhatsky <yurys at chromium.org> has denied Sergey Vorobyev
<sergeyvorobyev at google.com>'s request for review:
Bug 58064: Web Inspector: Network events don't preserves, when inspector
frontend closed and open again
https://bugs.webkit.org/show_bug.cgi?id=58064
Attachment 89787: Fix style
https://bugs.webkit.org/attachment.cgi?id=89787&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89787&action=review
> Source/WebCore/inspector/InspectorResourceAgent.cpp:106
> + m_frontend = m_mockFrontend.get();
You should clear pointer from the proxy to the channel, otherwise
m_inspectorFrontendProxy will continue sending events into the channel. r- for
this.
More information about the webkit-reviews
mailing list