[webkit-reviews] review granted: [Bug 58628] Make mac WebKit1 use the default localization strategy : [Attachment 89725] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 58628: Make mac WebKit1 use the default localization strategy
https://bugs.webkit.org/show_bug.cgi?id=58628

Attachment 89725: Patch
https://bugs.webkit.org/attachment.cgi?id=89725&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89725&action=review

r=me but see the  comments about comments.

> Source/WebCore/English.lproj/Localizable.strings:13
> -/* window title for a standalone image (uses multiplication symbol, not x)
*/
> +/* window title suffix for a standalone image (uses multiplication symbol,
not x) */

It's not a suffix, it's a format string, so this comment change is not an
improvement IMO.

> Source/WebCore/English.lproj/Localizable.strings:16
> -/* window title for a standalone image (uses multiplication symbol, not x)
*/
> +/* window title suffix for a standalone image (uses multiplication symbol,
not x) */

It's not a suffix, it's a format string, so this comment change is not an
improvement IMO.