[webkit-reviews] review granted: [Bug 58399] Web Inspector: Timeline is too narrow : [Attachment 89681] New patch, fixes changelog

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Annie Sullivan
<sullivan at chromium.org>'s request for review:
Bug 58399: Web Inspector: Timeline is too narrow
https://bugs.webkit.org/show_bug.cgi?id=58399

Attachment 89681: New patch, fixes changelog
https://bugs.webkit.org/attachment.cgi?id=89681&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89681&action=review

This looks good, thanks for doing it.

> Source/WebCore/ChangeLog:5
> +	   Changed Network Panel widths so that Timeline is 50%.

It should be:

WebInspector: Title
http://...
<optional blank line>
Multiline description here.

Changes digest.

> Source/WebCore/inspector/front-end/NetworkPanel.js:960
> +	       widths.timeline = 50;

It leaves 5% left, is that intentional? Did you check whether column resize
bars are aligned properly?

> Source/WebCore/inspector/front-end/NetworkPanel.js:1436
> +    _setTextAndTitle: function(element, text)

You could define setTextAndTitle on Elements' prototype in the utilities.js.