[webkit-reviews] review granted: [Bug 58592] WebKit2: Need a way to keep the WebProcess alive for testing purposes : [Attachment 89679] Patch

[bugzilla-daemon at webkit.org]

Brian Weinstein <bweinstein at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 58592: WebKit2: Need a way to keep the WebProcess alive for testing
purposes
https://bugs.webkit.org/show_bug.cgi?id=58592

Attachment 89679: Patch
https://bugs.webkit.org/attachment.cgi?id=89679&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89679&action=review

I feel like everywhere this should be webProcessCanTerminate instead of
webProcessCanTerminateEarly.

> Source/WebKit2/UIProcess/WebContext.cpp:267
> +    m_webProcessCanTerminateEarly = allowed;

Is an early return if allowed == m_webProcessCanTerminateEarly helpful?

> Source/WebKit2/UIProcess/WebContext.h:265
> +    bool m_webProcessCanTerminateEarly;

Blank line before this might be nice.

> Source/WebKit2/UIProcess/API/C/WKContextPrivate.h:64
> +// FIXME: This is a workaround for testing purposes only.

So is this the FIXME to remove this? I'm not sure what the FIXME represents
here.