[webkit-reviews] review granted: [Bug 58456] Add external file type enum and expose factory function for creating FileEntry and DirectoryEntry instances from Chromium side : [Attachment 89662] Added 'external' file system enum, few Chromium factory functions for File API objects

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Zelidrag Hornung
<zelidrag at chromium.org>'s request for review:
Bug 58456: Add external file type enum and expose factory function for creating
FileEntry and DirectoryEntry instances from Chromium side
https://bugs.webkit.org/show_bug.cgi?id=58456

Attachment 89662: Added 'external' file system enum, few Chromium factory
functions for File API objects
https://bugs.webkit.org/attachment.cgi?id=89662&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89662&action=review

R=me, CQ-

> Source/WebKit/chromium/public/WebFileSystem.h:43
> +#define WEB_FILE_SYSTEM_TYPE_EXTERNAL;

nit: no trailing ";"

please add a FIXME about removing this #define once the Chromium side has
caught up.