[webkit-reviews] review granted: [Bug 56493] Drag-scrolling overlay scrollbars thumb in overflow regions does not work : [Attachment 89509] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 14:49:57 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 56493: Drag-scrolling overlay scrollbars thumb in overflow regions does not
work
https://bugs.webkit.org/show_bug.cgi?id=56493

Attachment 89509: New patch
https://bugs.webkit.org/attachment.cgi?id=89509&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89509&action=review

> Source/WebCore/platform/ScrollView.cpp:927
> +    m_containsScrollableAreaWithOverlayScrollbars = false;

Init this in the constructor too?

> Source/WebCore/rendering/RenderLayer.cpp:2184
> +	   renderView->layer()->setContainsDirtyOverlayScrollbars(true);

I'm not sure what dirtyOverflowScrollbars are?


More information about the webkit-reviews mailing list