[webkit-reviews] review granted: [Bug 58570] Make creating WebPreferences lazy : [Attachment 89647] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 14:34:14 PDT 2011


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 58570: Make creating WebPreferences lazy
https://bugs.webkit.org/show_bug.cgi?id=58570

Attachment 89647: Patch
https://bugs.webkit.org/attachment.cgi?id=89647&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89647&action=review

> Source/WebKit2/ChangeLog:14
> +	   Don't create the WebPrefernece object until it is requested.

Typo

> Source/WebKit2/UIProcess/WebPageGroup.cpp:101
> +	   m_preferences->addPageGroup(this);

We don't need to call preferencesDidChange() here?


More information about the webkit-reviews mailing list