[webkit-reviews] review granted: [Bug 58561] Enable building Web Audio with MKL in Chrome-branded builds : [Attachment 89633] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 13:54:58 PDT 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 58561: Enable building Web Audio with MKL in Chrome-branded builds
https://bugs.webkit.org/show_bug.cgi?id=58561

Attachment 89633: Patch
https://bugs.webkit.org/attachment.cgi?id=89633&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89633&action=review

> Source/WebCore/platform/audio/fftw/FFTFrameFFTW.cpp:30
> +#if ENABLE(WEB_AUDIO) && !OS(DARWIN) && USE(WEBAUDIO_FFTW)

Can you separate the additional conditionals into a separate define?

> Source/WebCore/platform/audio/mkl/FFTFrameMKL.cpp:31
> +#if ENABLE(WEB_AUDIO) && !OS(DARWIN) && USE(WEBAUDIO_MKL)

Ditto.


More information about the webkit-reviews mailing list