[webkit-reviews] review denied: [Bug 58509] Add a sample test case for GTest framework : [Attachment 89523] Example test case for GTest in JavaScriptCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 13:27:09 PDT 2011

David Levin <levin at chromium.org> has denied Dmitry Lomov <dslomov at google.com>'s
request for review:
Bug 58509: Add a sample test case for GTest framework

Attachment 89523: Example test case for GTest in JavaScriptCore

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89523&action=review

Just a few suggestions.

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:3435
> +			buildSettings = {

Let's try to trim this down.

> Source/JavaScriptCore/wtf/tests/RunAllWtfTests.cpp:35
> +int main(int argc, char **argv) {

The { needs to be on the next line.

> Source/JavaScriptCore/wtf/tests/RunAllWtfTests.cpp:36
> +    std::cout << "Running main() from gtest_main.cc\n";

Avoid stream io for consistency for the rest of WebKit.

> Source/JavaScriptCore/wtf/tests/StringTests.cpp:41
> +TEST_F(CStringTest, TestLength) {

{ on next line.

> Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj:581
> +			developmentRegion = English;

Remove this to keep us the same as upstream.

More information about the webkit-reviews mailing list