[webkit-reviews] review granted: [Bug 58562] queues.webkit.org should display when a bot last rebooted : [Attachment 89632] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 13:16:55 PDT 2011

Mihai Parparita <mihaip at chromium.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 58562: queues.webkit.org should display when a bot last rebooted

Attachment 89632: Patch

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89632&action=review

> Tools/QueueStatusServer/templates/queuestatus.html:12
> +Last Pass: {{ last_pass.date|timesince }} ago

You may be able to move this to a sub-template that you then use {% with "foo"
as param %} {%include "summary_snippet.html" %} {% endwidth %}

However, this is kind of awkward pre-Django 1.3 (where you can specify the
parameters directly in the include tag:
de), since you need a with statement per parameter.

I'd say the repetition is fine for just two places.

More information about the webkit-reviews mailing list