[webkit-reviews] review granted: [Bug 58535] REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests) : [Attachment 89630] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 58535: REGRESSION (r83820): Lots of compositing tests failing on Windows 7
Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=58535

Attachment 89630: Patch
https://bugs.webkit.org/attachment.cgi?id=89630&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89630&action=review

>>> Source/WebCore/rendering/RenderLayerBacking.cpp:571
>>>  #endif
>> 
>> Now I wonder if these aren't all backwards. You want scrollbars layers in
Chromium. Mac/Windows _only_ wants them if there are overlay scrollbars. So I
think the logic is wrong.
> 
> On chromium this function returns true iff there is a horizontal scrollbar. 
On non-chromium this function returns true iff the page is using overlay
scrollbars _and_ there is a horizontal scrollbar.  Maybe there are too many
negations here to be clear?

I was confused by the early return. So this is OK.