[webkit-reviews] review denied: [Bug 58516] Have canvas drawImageFromRect just redirect to use drawImage : [Attachment 89608] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 14 11:15:38 PDT 2011
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 58516: Have canvas drawImageFromRect just redirect to use drawImage
https://bugs.webkit.org/show_bug.cgi?id=58516
Attachment 89608: Patch
https://bugs.webkit.org/attachment.cgi?id=89608&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89608&action=review
> Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:299
> -
ustringToString(exec->argument(9).toString(exec)));
> - return jsUndefined();
> +
ustringToString(exec->argument(9).toString(exec)), ec);
> + setDOMException(exec, ec);
> +
> + return jsUndefined();
This change looks unrelated. If you did intend to include it, then the
changelog should describe it, and the testcase should exercise it.
More information about the webkit-reviews
mailing list