[webkit-reviews] review denied: [Bug 51698] SVG pathsegs not sanitized before being passed through to platform Path : [Attachment 89597] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 09:52:51 PDT 2011


Andreas Kling <kling at webkit.org> has denied Ademar Reis
<ademar.reis at openbossa.org>'s request for review:
Bug 51698: SVG pathsegs not sanitized before being passed through to platform
Path
https://bugs.webkit.org/show_bug.cgi?id=51698

Attachment 89597: patch
https://bugs.webkit.org/attachment.cgi?id=89597&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Change itself is fine, but the test only covers one specific configuration of
the curveToCubic() code path. All three functions should be covered, and we
should verify that any of the coordinate arguments can be non-finite without
causing a crash.


More information about the webkit-reviews mailing list