[webkit-reviews] review granted: [Bug 58514] Creating a CairoPath instance is not thread safe : [Attachment 89546] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 08:12:46 PDT 2011

Martin Robinson <mrobinson at webkit.org> has granted Joone Hur
<joone.hur at collabora.co.uk>'s request for review:
Bug 58514: Creating a CairoPath instance is not thread safe

Attachment 89546: Proposed Patch

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89546&action=review

Looks good. Please move the two new files to PlatformPathCairo.* before
landing. Thanks!

> Source/WebCore/CMakeListsEfl.txt:94
> +    platform/graphics/cairo/PlatformCairoPath.cpp
>      platform/graphics/cairo/PlatformContextCairo.cpp

Probably better to name it PlatformPathCairo to match PlatformContextCairo.

> Source/WebCore/platform/graphics/cairo/PlatformCairoPath.h:22
> +#ifndef PlatformCairoPath_h
> +#define PlatformCairoPath_h

Don't forget to update these header guards when you move this to

> Source/WebCore/platform/graphics/cairo/PlatformCairoPath.h:35
> +    ~CairoPath()
> +    {
> +    }

You can place this on one line just like context().

> Source/WebCore/platform/graphics/cairo/PlatformCairoPath.h:45
> +#endif // CairoPath_h

Don't forget to update this header guard.

More information about the webkit-reviews mailing list