[webkit-reviews] review granted: [Bug 57038] Web Inspector: re-implement dom breakpoints. : [Attachment 86800] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 57038: Web Inspector: re-implement dom breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=57038

Attachment 86800: Patch.
https://bugs.webkit.org/attachment.cgi?id=86800&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86800&action=review

> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:54
> +WebInspector.DOMBreakpointsSidebarPane.instance = function()

We don't use singletons elsewhere. Why is this necessary?

> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:66
> +	   var fragmentIndex = url.indexOf("#");

I think we have this somewhere else as well. Should we move this to the
utilities.js?