[webkit-reviews] review denied: [Bug 58402] old-run-webkit-tests shouldn't write .checksum files : [Attachment 89313] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 06:16:15 PDT 2011

Adam Roben (:aroben) <aroben at apple.com> has denied Tony Chang
<tony at chromium.org>'s request for review:
Bug 58402: old-run-webkit-tests shouldn't write .checksum files

Attachment 89313: Patch

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89313&action=review

> Tools/Scripts/old-run-webkit-tests:936
> +	       if (-f $expectedChecksumPath) {
> +		   unlink $expectedChecksumPath;
> +	       }

This seems strange. People are going to have files disappearing from their
working trees without any explanation. I think it would be a lot better to just
do a one-time delete of all .checksum files in the WebKit tree and commit that

More information about the webkit-reviews mailing list