[webkit-reviews] review requested: [Bug 58447] Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size : [Attachment 89558] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has asked  for review:
Bug 58447: Web Inspector: ResourceResponse should have encodedDataLength field
for synchronous requests transfer size
https://bugs.webkit.org/show_bug.cgi?id=58447

Attachment 89558: Patch
https://bugs.webkit.org/attachment.cgi?id=89558&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
(In reply to comment #2)
> (From update of attachment 89386 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=89386&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:2829
> > +	 notifier()->sendRemainingDelegateMessages(m_documentLoader.get(),
identifier, response, data.size(),
static_cast<int>(response.encodedDataLength()), error);
> 
> what are the implications of this change?
This parameter was introduced by my previous change and the value passed here
was not correct. Now we are passing a correct value that will be forwarded to
didReceiveData.

> > Source/WebCore/platform/network/ResourceResponseBase.h:68
> > +	 long long encodedDataLength() const;
> 
> This should be a part of ResourceLoadInfo.
Done.