[webkit-reviews] review granted: [Bug 55552] Text selection changes unexpectedly when dragging out of the <input> : [Attachment 89527] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Alice Boxhall
<aboxhall at chromium.org>'s request for review:
Bug 55552: Text selection changes unexpectedly when dragging out of the <input>
https://bugs.webkit.org/show_bug.cgi?id=55552

Attachment 89527: Patch
https://bugs.webkit.org/attachment.cgi?id=89527&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89527&action=review

> Source/WebCore/page/EventHandler.cpp:660
> +    VisibleSelection newSelection = m_frame->selection()->selection();
> +    VisiblePosition targetPosition =
selectionExtentRespectingEditingBoundary(newSelection,
hitTestResult.localPoint(), target);

You can just pass m_frame->selection()->selection() here since you're not
modifying newSelection. That'll avoid copying VisibleSelection needlessly when
we're bailing out early.  Please make this change and I'll cq+ it.