[webkit-reviews] review denied: [Bug 55552] Text selection changes unexpectedly when dragging out of the <input> : [Attachment 89526] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 13 21:20:49 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has denied Alice Boxhall
<aboxhall at chromium.org>'s request for review:
Bug 55552: Text selection changes unexpectedly when dragging out of the <input>
https://bugs.webkit.org/show_bug.cgi?id=55552
Attachment 89526: Patch
https://bugs.webkit.org/attachment.cgi?id=89526&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89526&action=review
> Source/WebCore/page/EventHandler.cpp:641
> + return
selectionEndNode->renderer()->positionForPoint(selectionEndPoint);
You need to check renderer here as well.
> Source/WebCore/page/EventHandler.cpp:658
> if (!targetRenderer)
> return;
You should remove this early exit.
More information about the webkit-reviews
mailing list