[webkit-reviews] review requested: [Bug 56493] Drag-scrolling overlay scrollbars thumb in overflow regions does not work : [Attachment 89509] New patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 56493: Drag-scrolling overlay scrollbars thumb in overflow regions does not
work
https://bugs.webkit.org/show_bug.cgi?id=56493

Attachment 89509: New patch
https://bugs.webkit.org/attachment.cgi?id=89509&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
New patch! This patch fixes the |= bug that Simon pointed out above. It also
uses ScrollView to track whether there are any overlay scrollbars painted in
the view currently rather than trying to do something similar with the root
layer.

I started renaming OverlayScrollbarSizeRelevancy to
OverlayScrollbarSizeIncluded despite my protestations above. But in the end, I
reverted the change. The most obvious variable name for something of type
OverlayScrollbarSizeIncluded would be scrollbarSizeIncluded, which just makes
it sound like the scrollbar size IS included. We need a name that conveys that
the variable might mean that the size is included, or it might mean the size is
ignored. So yeah. I went back to the original protestations.