[webkit-reviews] review granted: [Bug 52763] generated unexpected_results.html from unexpected_results.json : [Attachment 89492] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 13 17:00:22 PDT 2011

Eric Seidel <eric at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 52763: generated unexpected_results.html from unexpected_results.json

Attachment 89492: Patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89492&action=review

I think this is a great first step.  I look forward to further iteration.  I
think you should fix the hard-coded layout test results path though. :)

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:53
> +var test_base_path =

There is a symlink for you in the results directory iirc.  There is an option
in old-run-webkit-tests to generate a results.html with remote links.

More information about the webkit-reviews mailing list