[webkit-reviews] review granted: [Bug 58483] GC allocate Structure : [Attachment 89472] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 13 15:42:08 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 58483: GC allocate Structure
https://bugs.webkit.org/show_bug.cgi?id=58483

Attachment 89472: Patch
https://bugs.webkit.org/attachment.cgi?id=89472&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89472&action=review

r=me

> Source/JavaScriptCore/bytecode/Instruction.h:146
> +	       u.structure.clear();

No need for clear here.

> Source/JavaScriptCore/runtime/StructureTransitionTable.h:154
> +	       HandleHeap::heapFor(slot)->makeWeak(slot, 0, 0);

No need for 0, 0 here.


More information about the webkit-reviews mailing list