[webkit-reviews] review denied: [Bug 58007] [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser : [Attachment 89430] Patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Keith Kyzivat
<keith.kyzivat at nokia.com>'s request for review:
Bug 58007: [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=58007

Attachment 89430: Patch
https://bugs.webkit.org/attachment.cgi?id=89430&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89430&action=review

Please fix the minor comment on the SYMBIAN section; otherwise looks good to
me.

> Tools/QtTestBrowser/launcherwindow.cpp:71
>  #if defined(Q_OS_SYMBIAN)
>      setWindowState(Qt::WindowMaximized);
>  #else

Perhaps you should move this special case for SYMBIAN to where we process the
-maximize option. Please do that for the MiniBrowser as well.