[webkit-reviews] review granted: [Bug 58073] Presence of shadow DOM should suppress rendering of ordinary child nodes : [Attachment 89466] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 58073: Presence of shadow DOM should suppress rendering of ordinary child
nodes
https://bugs.webkit.org/show_bug.cgi?id=58073

Attachment 89466: Patch
https://bugs.webkit.org/attachment.cgi?id=89466&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89466&action=review

> Source/WebCore/dom/Node.cpp:855
> +inline static ContainerNode* shadowRoot(Node* node)

I don't think this inline is really needed. We should reserve inline for cases
where we can actually show an improvement, no? But I'm a n00b so feel free to
ignore this. :)

> Source/WebCore/dom/Node.cpp:1460
> +inline static bool shouldCreateRendererFor(Node* node, ContainerNode*
parentForRenderingAndStyle)

ditto re: inline