[webkit-reviews] review denied: [Bug 52763] generated unexpected_results.html from unexpected_results.json : [Attachment 79513] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 13 14:44:56 PDT 2011
Eric Seidel <eric at webkit.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 52763: generated unexpected_results.html from unexpected_results.json
https://bugs.webkit.org/show_bug.cgi?id=52763
Attachment 79513: Patch
https://bugs.webkit.org/attachment.cgi?id=79513&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
abarth points out that our *.json files are JSONP files. We don't need to XHR
Them. WE just include them via a script tag afte defining an ADD_RESULTS
function: http://en.wikipedia.org/wiki/JSONP The python code here isn't
needed.
More information about the webkit-reviews
mailing list