[webkit-reviews] review granted: [Bug 58462] Media engine fallback doesn't always work : [Attachment 89424] Proposed patch.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 58462: Media engine fallback doesn't always work
https://bugs.webkit.org/show_bug.cgi?id=58462

Attachment 89424: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=89424&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89424&action=review

As discussed in person, it is wrong that we don't have a MIME type here -
WebKit knew it when it decided to create a media document. Passing the MIME
type down would be another way to fix this particular bug.

There are other ways to reach this code without a known MIME type, so the fix
is still useful.

> Source/WebCore/ChangeLog:8
> +	   No new tests, this was verified manually with the url noted in the
bug.

This doesn't really explain why there is no regression test.