[webkit-reviews] review denied: [Bug 58410] Extension3D needs to provide a way to check if an extension is enabled : [Attachment 89420] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 58410: Extension3D needs to provide a way to check if an extension is
enabled
https://bugs.webkit.org/show_bug.cgi?id=58410

Attachment 89420: Patch
https://bugs.webkit.org/attachment.cgi?id=89420&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89420&action=review

This looks good overall but there are a couple of issues.

> Source/WebCore/platform/graphics/Extensions3D.h:63
> +    virtual bool isEnabled(const String&) = 0;

This new method needs better documentation. I suggest:

"""
Takes full name of extension: for example, "GL_EXT_texture_format_BGRA8888".
Checks to see whether the given extension is actually enabled (see
ensureEnabled). Has no other side-effects.
"""

Also, I would add it underneath ensureEnabled, which will be folded into
supports() per bug 57393.

> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:113
> +#if PLATFORM(MAC)
> +    if (name == "GL_OES_standard_derivatives") {
> +	   // Enable support in ANGLE (if not enabled already)
> +	   ANGLEWebKitBridge& compiler = m_context->m_compiler;
> +	   ShBuiltInResources ANGLEResources = compiler.getResources();
> +	   return ANGLEResources.OES_standard_derivatives;
> +    }
> +#endif

This code is incorrect -- isEnabled() should not have any side-effects.