[webkit-reviews] review denied: [Bug 58459] Exclude webkitGetUserMedia from the navigator-detached-no-crash test : [Attachment 89412] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 58459: Exclude webkitGetUserMedia from the navigator-detached-no-crash test
https://bugs.webkit.org/show_bug.cgi?id=58459

Attachment 89412: Patch
https://bugs.webkit.org/attachment.cgi?id=89412&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89412&action=review

> LayoutTests/fast/dom/navigator-detached-no-crash.html:55
> +    if (p != 'geolocation' && p != 'webkitGetUserMedia') { // Don't include
Geolocation or the Media Stream API functions until most platforms have
support.

Better to use early return, like:
  if (p == 'geolocation' || p == 'webkitGetUserMedia') //...
    continue;
  ...