[webkit-reviews] review requested: [Bug 58463] Switch HTTP pipelining from user default to WebPreferences setting : [Attachment 89413] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 58463: Switch HTTP pipelining from user default to WebPreferences setting
https://bugs.webkit.org/show_bug.cgi?id=58463

Attachment 89413: Patch
https://bugs.webkit.org/attachment.cgi?id=89413&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

This replaces support for the WebKitEnableHTTPPipelining user
default with methods on the WebCore::Setting C++ class and
the WebPreference Objective-C class.  It also removes support
for the WebKitForceHTTPPipeliningPriorityHigh user default which
was not needed.

Source/WebCore:

Run these commands if you set the user defaults previously,
replacing "BUNDLE.ID" with your application's bundle ID:

defaults delete BUNDLE.ID WebKitEnableHTTPPipelining
defaults delete BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh

* WebCore.exp.in: Export Settings::httpPipeliningEnabled() and
Settings::setHTTPPipeliningEnabled().
* page/Settings.cpp:
(WebCore::Settings::gHTTPPipeliningEnabled): Added.
(WebCore::Settings::setHTTPPipeliningEnabled): Added.
(WebCore::Settings::httpPipeliningEnabled): Added.
* page/Settings.h:
(WebCore::Settings::setHTTPPipeliningEnabled): Added declaration.
(WebCore::Settings::httpPipeliningEnabled): Added declaration.
(WebCore::Settings::gHTTPPipeliningEnabled): Added declaration.
* platform/network/ResourceRequestBase.h:
(WebCore::isHTTPPipeliningEnabled): Removed declaration.
(WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed declaration.
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Switched
to using Settings::httpPipeliningEnabled().
(WebCore::readBooleanPreference): Removed.
(WebCore::isHTTPPipeliningEnabled): Removed.
(WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed.
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
using Settings::httpPipeliningEnabled().  Removed check for
shouldForceHTTPPipeliningPriorityHigh().
(WebCore::ResourceRequest::doUpdatePlatformRequest): Ditto.

Source/WebKit/mac:

* WebView/WebPreferences.mm:
(+[WebPreferences httpPipeliningEnabled]): Added.
(+[WebPreferences setHTTPPipeliningEnabled:]): Added.
* WebView/WebPreferencesPrivate.h:
(+[WebPreferences httpPipeliningEnabled]): Added declaration.
(+[WebPreferences setHTTPPipeliningEnabled:]): Added declaration.

Source/WebKit2:

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetHTTPPipeliningEnabled): Added.
(WKPreferencesGetHTTPPipeliningEnabled): Added.
* UIProcess/API/C/WKPreferencesPrivate.h:
(WKPreferencesSetHTTPPipeliningEnabled): Added declaration.
(WKPreferencesGetHTTPPipeliningEnabled): Added declaration.
---
 13 files changed, 133 insertions(+), 33 deletions(-)