[webkit-reviews] review denied: [Bug 58459] Exclude webkitGetUserMedia from the navigator-detached-no-crash test : [Attachment 89408] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 13 11:25:29 PDT 2011


Jian Li <jianli at chromium.org> has denied Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 58459: Exclude webkitGetUserMedia from the navigator-detached-no-crash test
https://bugs.webkit.org/show_bug.cgi?id=58459

Attachment 89408: Patch
https://bugs.webkit.org/attachment.cgi?id=89408&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89408&action=review

> LayoutTests/fast/dom/navigator-detached-no-crash.html:56
> +	 if (p != 'webkitGetUserMedia') { // Don't include the Media Stream API
functions until most platforms have support.

Can you combine this logic with the existing check for "geolocation" into some
common check? Maybe you can keep an excluding list and check this list in for
loop.


More information about the webkit-reviews mailing list