[webkit-reviews] review denied: [Bug 58383] Fix bug with adding wrong context to LayerRendererChromium and get rid of RefPtr loop. : [Attachment 89388] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied John Bates <jbates at google.com>'s
request for review:
Bug 58383: Fix bug with adding wrong context to LayerRendererChromium and get
rid of RefPtr loop.
https://bugs.webkit.org/show_bug.cgi?id=58383

Attachment 89388: Patch
https://bugs.webkit.org/attachment.cgi?id=89388&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89388&action=review

Looks good overall. Did you test this both with and without the
GL_CHROMIUM_latch extension exposed from the command buffer service code, and
do page reloads, verifying that the assertion failure is fixed when the
extension isn't present, and that there is no memory leak (in either the
renderer or GPU process) when it is?

r- just because the ChangeLogs need the synopsis updated. I recommend rerunning
prepare-ChangeLog.

> Source/WebCore/ChangeLog:5
> +	   workaround possible HashMap RefPtr key bug

Please update this synopsis.

> Source/WebKit/chromium/ChangeLog:5
> +	   workaround possible HashMap RefPtr key bug

Please update synopsis.