[webkit-reviews] review granted: [Bug 55909] new-run-webkit-tests --run-singly option is busted : [Attachment 89278] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 13 10:28:07 PDT 2011

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 55909: new-run-webkit-tests --run-singly option is busted

Attachment 89278: Patch

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89278&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:170
> +	       def run(other):
> +		   self._result = worker._run_single_test(driver, test_input)

I think it's more common to do something like:

def run(self, worker_mixin=self):
    worker_mixin._result = ...

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:328
> +	   res, out, err, user = logging_run(['--run-singly',

Nit: maybe replace the unused outputs with _

More information about the webkit-reviews mailing list