[webkit-reviews] review denied: [Bug 58295] new-run-webkit-tests: suppress extraneous pretty patch warnings : [Attachment 89144] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 13 09:56:57 PDT 2011

Ojan Vafai <ojan at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 58295: new-run-webkit-tests: suppress extraneous pretty patch warnings

Attachment 89144: Patch

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89144&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:178
> +    def check_pretty_patch(self, logger=None):

It seems wrong that we're calling this method multiple times. How about making
a pretty_patch_available method for pretty_patch_text and check_pretty_patch to

More information about the webkit-reviews mailing list