[webkit-reviews] review granted: [Bug 58024] [GTK] Implement page loader client in MiniBrowser : [Attachment 88602] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 58024: [GTK] Implement page loader client in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=58024

Attachment 88602: Patch
https://bugs.webkit.org/attachment.cgi?id=88602&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88602&action=review

Nice.

> Tools/MiniBrowser/gtk/BrowserWindow.c:372
> +    WKPageLoaderClient loadClient = {
> +	   0,	    /* version */
> +	   window, /* clientInfo */
> +	   didStartProvisionalLoadForFrame,
> +	   didReceiveServerRedirectForProvisionalLoadForFrame,
> +	   didFailProvisionalLoadWithErrorForFrame,
> +	   didCommitLoadForFrame,
> +	   didFinishDocumentLoadForFrame,
> +	   didFinishLoadForFrame,
> +	   didFailLoadWithErrorForFrame,
> +	   0, /* didSameDocumentNavigationForFrame */
> +	   didReceiveTitleForFrame,
> +	   didFirstLayoutForFrame,
> +	   didFirstVisuallyNonEmptyLayoutForFrame,
> +	   didRemoveFrameFromHierarchy,
> +	   0, /* didDisplayInsecureContentForFrame */
> +	   0, /* didRunInsecureContentForFrame */
> +	   0, /* canAuthenticateAgainstProtectionSpaceInFrame */
> +	   0, /* didReceiveAuthenticationChallengeInFrame */
> +	   didStartProgress,
> +	   didChangeProgress,
> +	   didFinishProgress,
> +	   didBecomeUnresponsive,
> +	   didBecomeResponsive,
> +	   0,  /* processDidCrash */
> +	   0,  /* didChangeBackForwardList */
> +	   0   /* shouldGoToBackForwardListItem */
> +    };
> +    WKPageSetPageLoaderClient(WKViewGetPage(window->webView), &loadClient);

Do you mind lining up the comments on these lines?

> Tools/MiniBrowser/gtk/BrowserWindow.c:376
> +GtkWidget* browserWindowNew(WKViewRef view)

Minor bikeshed. Since BrowserWindow is a GObject, I think the public methods
should have g_object_naming_style.