[webkit-reviews] review granted: [Bug 58387] make PrettyPatch.rb aware of checksums in png files : [Attachment 89289] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Tony Chang
<tony at chromium.org>'s request for review:
Bug 58387: make PrettyPatch.rb aware of checksums in png files
https://bugs.webkit.org/show_bug.cgi?id=58387

Attachment 89289: Patch
https://bugs.webkit.org/attachment.cgi?id=89289&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89289&action=review

> Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:544
> +		       @image_urls = binary_contents.collect do |content|
> +			   "data:image/png;base64," + [content].pack("m")
> +		       end
> +
> +		       @image_checksums = binary_contents.collect do |content|
> +			   FileDiff.read_checksum_from_png(content)
> +		       end

These might read a little better if you used block syntax:

@image_urls = binary_contents.collect { |content| "data:image/png;base64," +
[content].pack("m") }