[webkit-reviews] review denied: [Bug 58322] Web Inspector: Web Page Performance auditing fails : [Attachment 89227] [PATCH] DOMAgent.requestDocument() fixed (for pfeldman to have a look)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 13 02:00:58 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 58322: Web Inspector: Web Page Performance auditing fails
https://bugs.webkit.org/show_bug.cgi?id=58322

Attachment 89227: [PATCH] DOMAgent.requestDocument() fixed (for pfeldman to
have a look)
https://bugs.webkit.org/attachment.cgi?id=89227&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89227&action=review

> Source/WebCore/inspector/front-end/AuditRules.js:362
> +		       WebInspector.domAgent.querySelector(document.id,
selectors[i], queryCallback.bind(null, i === selectors.length - 1 ?
selectorsCallback.bind(null, callback, styleSheets, testedSelectors) : null,
selectors[i], styleSheets, testedSelectors));

You should requestDocument within DOMAgent.js::querySelector instead. I thought
Andrey has fixed it already - he had a patch pending.
Also I can't parse this string - you should extract variables for bound
functions, etc.


More information about the webkit-reviews mailing list