[webkit-reviews] review granted: [Bug 58340] Web Inspector: another pass of protocol renames. : [Attachment 89345] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 58340: Web Inspector: another pass of protocol renames.
https://bugs.webkit.org/show_bug.cgi?id=58340

Attachment 89345: Patch
https://bugs.webkit.org/attachment.cgi?id=89345&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89345&action=review

> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:56
> +	   injectedScript.evaluate(errorString, expression, objectGroup ?
*objectGroup : "", includeCommandLineAPI ? *includeCommandLineAPI : false,
result);

Conversions like objectGroup ? *objectGroup : "" can well be made in generated
dispatcher code, that would simplify agents code a bit.