[webkit-reviews] review denied: [Bug 58401] Enable folder drag-n-drop when using a "webkitdirectory" file input : [Attachment 89318] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied John Gregg
<johnnyg at google.com>'s request for review:
Bug 58401: Enable folder drag-n-drop when using a "webkitdirectory" file input
https://bugs.webkit.org/show_bug.cgi?id=58401

Attachment 89318: Patch
https://bugs.webkit.org/attachment.cgi?id=89318&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89318&action=review

> Source/WebKit/chromium/public/WebViewClient.h:175
> +    virtual bool enumerateDirectory(const WebString& path,

enumerateChosenDirectory might be a better name here.  you want to convey the
fact
that only chosen directories may be enumerated, right?	any reason not to name
it
like this?

this function shouldn't live in the "editing" section of WebViewClient.  it
might be
nice to group it with runFileChooser, since the two functions are related. 
however,
that lives in a section for "dialogs" :(  maybe put this in the "misc" section
nearby
the queryIconForFiles method?