[webkit-reviews] review denied: [Bug 55552] Text selection changes unexpectedly when dragging out of the <input> : [Attachment 89322] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 12 18:19:54 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has denied Alice Boxhall
<aboxhall at chromium.org>'s request for review:
Bug 55552: Text selection changes unexpectedly when dragging out of the <input>
https://bugs.webkit.org/show_bug.cgi?id=55552
Attachment 89322: Patch
https://bugs.webkit.org/attachment.cgi?id=89322&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89322&action=review
> Source/WebCore/page/EventHandler.cpp:638
> + FloatPoint absolutePoint =
targetNode->renderer()->localToAbsolute(FloatPoint(selectionEndPoint));
> +
> + selectionEndPoint =
roundedIntPoint(selectionEndNode->renderer()->absoluteToLocal(absolutePoint));
> + }
> +
> + return
selectionEndNode->renderer()->positionForPoint(selectionEndPoint);
Oops, these nodes may not have renderers.
More information about the webkit-reviews
mailing list