[webkit-reviews] review granted: [Bug 58403] Rename onEndChain and make it a static method. : [Attachment 89316] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 17:46:28 PDT 2011

Eric Seidel <eric at webkit.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 58403: Rename onEndChain and make it a static method.

Attachment 89316: Patch.

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89316&action=review

Otherwise LGTM.  If you're a committer, you can just add the two keywords when
you land, otherwise you'll need to post a new patch.  Thanks!

> Source/WebCore/rendering/InlineFlowBox.cpp:255
> +bool isLastChildForRenderer(RenderObject* ancestor, RenderObject* child)

Should mark it static and possibly inline.

More information about the webkit-reviews mailing list