[webkit-reviews] review granted: [Bug 58392] WebKit2: Frames prevent scrolling containing page : [Attachment 89302] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 58392: WebKit2: Frames prevent scrolling containing page
https://bugs.webkit.org/show_bug.cgi?id=58392

Attachment 89302: Patch
https://bugs.webkit.org/attachment.cgi?id=89302&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89302&action=review

> Source/WebCore/page/FrameView.cpp:144
> +	       if (m_page->mainFrame() == m_frame) {

This test feels backwards.

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:792
> +    if (fabsf(wheelEvent.deltaY()) >= fabsf(wheelEvent.deltaX())) {

Add a FIXME to fix this?