[webkit-reviews] review granted: [Bug 58291] REGRESSION: Vimeo fullscreen video displays incorrectly : [Attachment 89242] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 15:27:37 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 58291: REGRESSION: Vimeo fullscreen video displays incorrectly
https://bugs.webkit.org/show_bug.cgi?id=58291

Attachment 89242: Patch
https://bugs.webkit.org/attachment.cgi?id=89242&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89242&action=review

> Source/WebCore/css/fullscreen.css:16
> +    background-color: black ! important;
> +    position: static ! important;
> +    margin: 0 ! important;
> +    height: 100% ! important;
> +    width: 100% ! important;
> +    -webkit-box-flex: 1 ! important;
> +    display: block ! important;

We don't put a space after the ! normally.

> Source/WebCore/html/HTMLMediaElement.cpp:1495
> +    // always show controls when in full screen mode.

Should use sentence case.


More information about the webkit-reviews mailing list