[webkit-reviews] review granted: [Bug 58272] new-run-webkit-tests: --results-directory is relative to builddir, not $PWD : [Attachment 89246] rebase, use port.get_option() instead of getattr
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 12 14:50:49 PDT 2011
Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 58272: new-run-webkit-tests: --results-directory is relative to builddir,
not $PWD
https://bugs.webkit.org/show_bug.cgi?id=58272
Attachment 89246: rebase, use port.get_option() instead of getattr
https://bugs.webkit.org/attachment.cgi?id=89246&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89246&action=review
Sorry, I was just confused. I was thinking you would just fix absolute paths,
then fix the bots, then land this patch. This is fine too.
> Tools/ChangeLog:14
> + This patch includes a hack to treat a value of '..' as special
> + to keep the Chromium bots from breaking; the hack can be removed
> + once the bots have been updated.
Remove this comment since it's no longer accurate.
More information about the webkit-reviews
mailing list