[webkit-reviews] review denied: [Bug 58375] [Qt] QNetworkReplyHandler refactoring: remove nested event loop. : [Attachment 89273] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Luiz Agostini <luiz at webkit.org>'s
request for review:
Bug 58375: [Qt] QNetworkReplyHandler refactoring: remove nested event loop.
https://bugs.webkit.org/show_bug.cgi?id=58375

Attachment 89273: patch
https://bugs.webkit.org/attachment.cgi?id=89273&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89273&action=review

Nice cleanup, just one thing-

> Source/WebCore/ChangeLog:37
>  
>  2011-04-12  Luiz Agostini  <luiz.agostini at openbossa.org>
>  

This hunk doesn't start at the top of the ChangeLog file :)

> Source/WebCore/platform/network/qt/ResourceHandleQt.cpp:192
> +    // starting in deferred mode gives d->m_job the chance of being set
before sending the request.
> +    d->m_job = new QNetworkReplyHandler(handle.get(),
QNetworkReplyHandler::SynchronousLoad, true);
> +    d->m_job->setLoadingDeferred(false);

This would be much less mysterious if QNetworkReplyHandler had a start() method
that we would explicitly call from the outside.