[webkit-reviews] review granted: [Bug 51790] [WinCairo] Patch to download the WinCairo dependencies as part of build-webkit. : [Attachment 89269] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 51790: [WinCairo] Patch to download the WinCairo dependencies as part of
build-webkit.
https://bugs.webkit.org/show_bug.cgi?id=51790

Attachment 89269: Patch
https://bugs.webkit.org/attachment.cgi?id=89269&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89269&action=review

> Tools/Scripts/build-webkit:512
> +    if(isWinCairo()) {

Missing space after "if".

> Tools/Scripts/update-webkit-dependency:56
> +sub getLibraryName;

You should add the prototype here, too.

> Tools/Scripts/update-webkit-dependency:154
> +    my $path = shift;
> +    my ($volume, $directory, $file) = File::Spec->splitpath($path);

Hm, splitpath doesn't seem right, since $path is really a URL. You should
rename $path to $url, and use the regex solution I think.