[webkit-reviews] review granted: [Bug 58292] Provide new setting to allow site icon loading despite disabling automatic image loading in general. : [Attachment 89241] patch - moved pref to [|I]WebPreferencesPrivate.[h|idl]

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 13:06:21 PDT 2011


Sam Weinig <sam at webkit.org> has granted Alice Liu <alice.liu at apple.com>'s
request for review:
Bug 58292: Provide new setting to allow site icon loading despite disabling
automatic image loading in general.
https://bugs.webkit.org/show_bug.cgi?id=58292

Attachment 89241: patch - moved pref to [|I]WebPreferencesPrivate.[h|idl]
https://bugs.webkit.org/attachment.cgi?id=89241&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89241&action=review

> Source/WebCore/loader/FrameLoader.cpp:712
> +    if (settings && !settings->loadsImagesAutomatically() &&
!settings->loadsSiteIconsIgnoringImageLoadingSetting())
> +	    return;
>  

Looks like you added an extra space here.


More information about the webkit-reviews mailing list