[webkit-reviews] review granted: [Bug 57459] REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html : [Attachment 89149] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 12:52:42 PDT 2011


Eric Seidel <eric at webkit.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 57459: REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html
https://bugs.webkit.org/show_bug.cgi?id=57459

Attachment 89149: Patch.
https://bugs.webkit.org/attachment.cgi?id=89149&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think the end result is that "onEndChain" never made any sense.  Now it makes
a differnet amount of non-sense, but seems to have the right behavior. We
should split it off into a static-inline with a nice name, near the one place
it's used. I don't think it makes any sense on InlineFlowBox.  It also probably
only makes sense to call it on RootInlineBoxes, no?  Your change seems fine
though.  THanks for all the info.


More information about the webkit-reviews mailing list