[webkit-reviews] review granted: [Bug 58288] webkitpy: fix mock_filesystem abspath to handle relative paths : [Attachment 89244] fix bug in abspath, clean up handling of directories and normalized paths

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 58288: webkitpy: fix mock_filesystem abspath to handle relative paths
https://bugs.webkit.org/show_bug.cgi?id=58288

Attachment 89244: fix bug in abspath, clean up handling of directories and
normalized paths
https://bugs.webkit.org/attachment.cgi?id=89244&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89244&action=review

OK.  Seems reasonable.

> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:52
> +	   self.dirs = {}

I"m unclear on exactly what this does.	I assume this is dirs for the cwd?  Or
is this all dirs for the mock file system? I'm unclear why its part of thsi
change, but I also doubt it matters. :)